Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBM Cloud Shell: re-gen provider for adopting the new error toolchain #5886

Closed
wants to merge 3 commits into from
Closed

IBM Cloud Shell: re-gen provider for adopting the new error toolchain #5886

wants to merge 3 commits into from

Conversation

Afreen1998
Copy link
Contributor

PR Details

  • Changes for IBM Cloud Shell - Optimize Terraform Error Messaging.
  • New version of platform-services-go-sdk - 0.72.0 to Optimize Terraform Error Messaging for cloudshell.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

  1. make build
afrinkatageri@Afrins-MacBook-Pro tf-new % make build
==> Checking that code complies with gofmt requirements...
go vet .
go install
afrinkatageri@Afrins-MacBook-Pro tf-new % 

$ make testacc TESTARGS='-run=TestAccXXX'

...

hkantare
hkantare reviewed Jan 2, 2025
View reviewed changes
ibm/service/cloudshell/resource_ibm_cloud_shell_account_settings.go
}

d.SetId(*accountSettings.ID)
d.SetId(fmt.Sprintf("%s/%s", *updateAccountSettingsOptions.AccountID, *accountSettings.AccountID))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break all the existing user's
To test this behavior
Use some latest released version to provision or create the resource
then use local build provider and run plan or apply it breaks

@hkantare
Copy link
Collaborator

hkantare commented Jan 2, 2025

Fix the conflicts by re-basing to latest master

@hkantare
Copy link
Collaborator

hkantare commented Jan 2, 2025

Resource specific testcases will be executed using below command

make testacc TEST=./ibm/service/cloudshell TESTARGS='-run=TestAccIBMCloudShellAccount'

Attach testcase results

@Afreen1998
Copy link
Contributor Author

Created a new PR with the required fixes #5904. Closing this PR.

@Afreen1998 Afreen1998 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Afreen1998 @hkantare